Pull Request Checklist

• Have you updated the documentation, if impacted (e.g. docs.status.im)?

Jenkins Builds

@yenda you can take this branch instead of #1467. it will download all historical transfers. for erc20 i am using getLogs for range of blocks. and eth is downloaded by comparing balance between ranges of blocks. so eth downloader might be a bit slow.

@pombeirp @adambabik since you guys already reviewed previous PR you can help me with this one :)

will implement better algorithm for finding eth transfers in a followup PR

@dshulyak I get this error a few seconds after login:
https://gist.github.com/yenda/5aa89b865af7ec752b5f34d32b615e43

here is the node config
https://gist.github.com/yenda/8fdcc165049b573c51d74cf45cb8f25e

there is a bug in ethclient https://github.com/ethereum/go-ethereum/blob/master/ethclient/ethclient.go#L243-L251 it doesn't check an error. i pushed a workaround and will submit a fix for it

made a fix here ethereum/go-ethereum#19653

@yenda btw can you give me an address that you are using? i want to run it with my script

@dshulyak 0x5DC6108dC6296b052BBd33000553AfE0Ea576b5E

I am not sure how to use wallet_getTransfers
In the json-rpc api block numbers are passed in hex, here it seems like it takes an integer

If I pass [7773254 nil] I get nothing, is it because the range start is the most recent block and end the oldest in the api? it is a bit confusing so the doc could be clarified on that
If I pass [nil nil] the app crashes https://gist.github.com/yenda/6c0ce03c321c05bc3ba354ef01e84248

This is all the params I tried with 0x5dc6108dc6296b052bbd33000553afe0ea576b5e:

status-im.ethereum.json-rpc> (call {:method "wallet_getTransfers" :on-success println :params [783254 7773254]})
nil

status-im.ethereum.json-rpc> (call {:method "wallet_getTransfers" :on-success println :params [773254 7873254]})
nil

status-im.ethereum.json-rpc> (call {:method "wallet_getTransfers" :on-success println :params [7773254 7873254]})
nil

status-im.ethereum.json-rpc> (call {:method "wallet_getTransfers" :on-success println :params [7773254 nil]})
nilnil

status-im.ethereum.json-rpc> (call {:method "wallet_getTransfers" :on-success println :params [7873254 nil]})
nil

status-im.ethereum.json-rpc> (call {:method "wallet_getTransfers" :on-success println :params [7873346 nil]})
nil

status-im.ethereum.json-rpc> (call {:method "wallet_getTransfers" :on-success println :params [nil nil]})
crash

If I pass [7773254 nil] I get nothing, is it because the range start is the most recent block and end the oldest in the api? it is a bit confusing so the doc could be clarified on that

it gets all transfers from first block till the last if last is not provided query will have no limit. query works in forward order if second blocks is lower that the first probably nothing will be selected

as for the first one is nil i will handle that.

have you tried to query using 0 as a first parameter?

In the json-rpc api block numbers are passed in hex, here it seems like it takes an integer

i will change it to hex

examples:

{"jsonrpc":"2.0","id":14,"method":"wallet_getTransfers","params":[0,20]}
{"jsonrpc":"2.0","id":14,"method":"wallet_getTransfers","params":[0,null]}
{"jsonrpc":"2.0","id":13,"method":"wallet_getTransfers","params":[0]}

changes in last commit:

• More debug info when node is stopped
• low keys in events
• send history event only if new transfers were found

can you turn on debug logging for status-go? i wasn't able to repro 1st issue. but added couple of enhancements and logs when service is stopped